Update rkyv 0.7.40 and prettytable-rs to 0.10.0 #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
approved these changes
Feb 20, 2023
|
Approved, although I think we already talked bumping rkyv would require a bumped magic version since the serialized data would be a bit improved |
|
We did talk about that, but since the update didn't fixed the fuzz issue, I have not bumped the magic. I still can do it. |
|
I'm happy either way, just wanted to make sure we are doing a intentional decision there |
|
Increasing MAGIC is not without consequences, so I prefer to do it only when needed or really beneficial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of some craye dependancies:
rkyv to 0.7.40 (but this doesn't fix #3576 )
prettytable-rs to 0.10.0 (github security warning about the old version used, moderate severity)